Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic OR query #240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louisch
Copy link

@louisch louisch commented Sep 20, 2022

Hi, I wanted to take a crack at this issue here: #89

I've made a very basic POC that just adds the ability to do an OR query on the first level, haven't made it work recursively yet, only made sure that the type checks pass and the test I created passes.

Just wanted to make sure that @kettanaito was okay with the general direction of this PR, and if you have any improvement or suggestions you have for me, especially about the types, because quite frankly I'm not a Typescript expert, and the code style as well.

Next would probably be making this actually recursive, and then trying to add AND as well.

@louisch louisch changed the title feat: add single level OR query feat: add basic OR query Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant