Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch: Gets JSON body only if the respective Content-Type is set #151

Merged
merged 1 commit into from
May 11, 2020
Merged

fetch: Gets JSON body only if the respective Content-Type is set #151

merged 1 commit into from
May 11, 2020

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented May 11, 2020 •
edited
Loading

Changes

  • Removes the Promise chain in graceful utility function.
  • Improves error handling, as exceptions during res.json()/res.text() will now bubble to the call surface.
  • Fixes an issue that resulted into res.text() being called when the response stream is locked.

GitHub

@kettanaito kettanaito merged commit 23569ef into master May 11, 2020
@kettanaito kettanaito deleted the 150-ctx-fetch-body-stream-closed branch May 11, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to execute 'text' on 'Response': body stream is locked
1 participant
@kettanaito