fix: removes request parsing from "onUnhandledRequest" #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcosta7
approved these changes
Jan 22, 2024
mattcosta7
reviewed
Jan 22, 2024
| "@types/statuses": "^2.0.4", | ||
| "chalk": "^4.1.2", | ||
| "chokidar": "^3.4.2", | ||
| "graphql": "^16.8.1", | ||
| "headers-polyfill": "^4.0.2", | ||
| "inquirer": "^8.2.0", | ||
| "is-node-process": "^1.2.0", | ||
| "js-levenshtein": "^1.1.6", |
|
Module graph on Module graph on this branch: Nice improvement :) |
|
@thepassle, that is amazing. All thanks to @mattcosta7 and you for pointing these things out. Let's have this released! |
Especially consider that we went from: To: |
Released: v2.1.4 🎉This has been released in v2.1.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a breaking change because the behavior modified is not connected to what MSW promises the developer. This is a warning message change, basically. But it has huge performance implications for everyone:
graphqlfor everyone even if they aren't using thegraphqlhandler;