🐛Force usage of chokidar 3 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @cowboyd. Thanks for preparing this.
This is a fair point. The library itself is bundled via Rollup. We use webpack to bundle usage examples (which are also test scenarios) and establish a dev server that's used in tests. I suppose something similar can be done with Rollup, either with native plugins, or manually (build + Express server, for example). I wouldn't tackle it here, but it's a noteworthy point. |
kettanaito
previously approved these changes
Jul 28, 2020
Motivation ---------- fixes mswjs#188 The current version of webpack that we're using has [a bug][1] that causes the tests to crashes on MacOS with some regularity. That is because it depends on chokidar 2 which uses the `fsevents` api which has a [crictical bug][2] on MacOS. Approach -------- This manually forces all modules to use chokidar 3 which does not use the `fsevents` module at all. While this does trigger a semver violation because webpack 4 depends on chokidar 2, the API is apparently similar enough that all the tests pass. It does however give rise to a warning in the console upon installation of depedencies via a `yarn`. This resolution can be removed once an upgrade is made to webpack 5 or to a different depedency bundler like [parcel][3] or [rollup][4]. Learning -------- * [Selective dependency resolutions ][5] [1]: webpack/webpack#10037 [2]: fsevents/fsevents#314 [3]: http://parceljs.org [4]: https://rollupjs.org [5]: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/
kettanaito
force-pushed
the
force-chokidar-3
branch
from
309213c
to
c7645c7
Compare
kettanaito
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fixes #188
The current version of webpack that we're using has a bug that causes the tests to crashes on MacOS with some regularity. That is because it depends on chokidar 2 which uses the
fseventsapi which has a crictical bug on MacOS.Approach
This manually forces all modules to use chokidar 3 which does not use the
fseventsmodule at all. The v3 API is apparently similar enough that webpack is able to use it as a drop-in replacement for v2. Howeve, it is worth noting that because this is technically a semver violation, it will cause a console warning every time ayarn installis run.This resolution can be removed once an upgrade is made to webpack 5 or to a different depedency bundler like parcel or rollup.
Learning