-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom transformers #441
feat: add custom transformers #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments
Works for me ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this, @marcosvega91!
I've flattened the createResponseComposition
options so we don't have to deal with default + custom options merging when given partial options object. The library now publicly exposes certain response-related TypeScript definitions so it's possible to use our internal functions and have type safety.
Looks great, I'm looking forward for the CI to pass.
I think it would be great to add this as a recipe to the docs. |
I'm really bad writing things. Also my English is not very good, so feel free to open a PR with your changes 😉. Thanks @timdeschryver :) |
@marcosvega91, thank you once more for adding these changes, Marco :) |
It's always a pleasure 🙂 |
fix #440
This PR will add support for
defaultTransformers
. This could be useful if you want to apply your own body transformation as for the issue.Now the function
createResponseComposition
is exported from the library. Users could create there own response function like