Makes "ctx.data" and "ctx.errors" input types compatible with "ExecutionResult" of "graphql"

[kettanaito]

GitHub

• Fixes ctx.data() and ctx.error() types are incompatible with graphql package ExecutionResult result type #522

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26885dd:

Sandbox	Source
MSW React	Configuration

[kettanaito]

Hey, @ericbiewener. This pull request should fix the issue you've described.

Could you please check if these changes work for you? You can use the Codesandbox preview project above to experiment directly in the sandbox environment or install this pull request in your project.

Surprisingly, there was no need to change ctx.data, as it's never typed as undefined:

// Type definitions of the "graphql" package
export interface ExecutionResult<
  TData = { [key: string]: any },
  TExtensions = { [key: string]: any }
> {
  errors?: ReadonlyArray<GraphQLError>;
  // TS_SPECIFIC: TData. Motivation: https://github.com/graphql/graphql-js/pull/2490#issuecomment-639154229
  data?: TData | null;
  extensions?: TExtensions;
}

[kettanaito]

Hey, @timdeschryver 👋 Sorry for troubling you. May I ask you for a quick review of these changes? Thanks!

[timdeschryver]

👍 LGTM, I think we already had fixed the issue with ctx.data because I also wasn't able to reproduce that.