fix: add client guards in service worker #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 411c381:
|
kettanaito
force-pushed
the
message-guards
branch
from
1b714a1
to
411c381
Compare
kettanaito
reviewed
Jan 26, 2021
kettanaito
reviewed
Jan 26, 2021
kettanaito
reviewed
Jan 26, 2021
kettanaito
reviewed
Jan 26, 2021
| @@ -49,6 +49,11 @@ export function setupWorker( | |||
| navigator.serviceWorker, | |||
| 'message', | |||
| (event: MessageEvent) => { | |||
| // Avoid messages broadcasted from unrelated workers. | |||
| if (event.source !== context.worker) { | |||
There was a problem hiding this comment.
I think this is a good enhancement described in this article.
Since we establish a global listener on navigator.serviceWorker, it can receive messages from other workers that may control the current client. With this check we're proceeding with event handling only if the source of the event (message) is our MSW worker.
kettanaito
approved these changes
Jan 26, 2021
|
Thank you for tackling this, @timdeschryver 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #536
This PR adds guard clauses to prevent the service worker throwing errors when the client isn't found.
Making this a draft until we can reproduce the behavior in #536