Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix renamed type (OnUnhandledRequest -> UnhandledRequestStrategy) #577

Merged
merged 1 commit into from Feb 3, 2021
Merged

fix renamed type (OnUnhandledRequest -> UnhandledRequestStrategy) #577

merged 1 commit into from Feb 3, 2021

Conversation

robbtraister
Copy link
Contributor

This type seems to have been renamed in the most recent release.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc65bb8:

Sandbox Source
MSW React Configuration

timdeschryver
timdeschryver previously approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!
I wonder how this wasn't caught by the build/tests 🤔

@kettanaito
Copy link
Member

Thank you for this fix, @robbtraister!

Strangely enough, yarn build compiles without type violations. yarn lint doesn't catch that either.

kettanaito
kettanaito previously approved these changes Feb 2, 2021
View reviewed changes
@kettanaito
Copy link
Member

Running tsc does report the build error. Looks like our Rollup configuration is silencing certain output.

@timdeschryver timdeschryver mentioned this pull request Feb 3, 2021
Closed
@kettanaito kettanaito dismissed stale reviews from timdeschryver and themself via dc65bb8 February 3, 2021 09:18
kettanaito
kettanaito approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, @robbtraister! Welcome to contributors 🎉

@kettanaito kettanaito merged commit 1769a1e into mswjs:master Feb 3, 2021
@ipanasenko
Copy link

Hi! Do you have an ETA for releasing this fix? I had to lock version to 0.26.0 in order to not break my build. Would love to have it unlocked again :)

@robbtraister
Copy link
Contributor Author

@ipanasenko I did the same thing, but an alternative (if you're really opposed to pinning) is to add skipLibCheck to your tsc command or tsconfig.

@kettanaito
Copy link
Member

@ipanasenko we will release this in 1-2 days. Thanks for the patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito approved these changes

@timdeschryver timdeschryver timdeschryver left review comments

Assignees
No one assigned
Labels
release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robbtraister @kettanaito @ipanasenko @timdeschryver