fix: broken links to GitHub repositories for v1 examples #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mshaaban088 is attempting to deploy a commit to the MSW Team on Vercel. A member of the Team first needs to authorize it. |
Following are the links that were updated to point to v1
- API types
- React
- REST API
- GraphQL API
- Angular
- REST API
- Libraries & Frameworks
- Storybook
- Redux Saga
- Karma
mshaaban088
changed the title
kettanaito
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Thanks for fixing this but I'm afraid V1 is readonly. It's such an old stack that it simply won't build anymore. Vercel stopped supporting the Node version V1 is built on. Sadly, I don't have the time to migrate it to be functional. Neither I think it should be a priority, given I recommend everyone using MSW 2.0 as the default from now on.
|
Thanks @kettanaito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following are the links that were updated to point to v1