Unit test bugs fixed.

msyk · May 23, 2024 · 090edfa · 090edfa
1 parent bfc435e
commit 090edfa
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/spec/INTER-Mediator-UnitTest/DB-PDO/DB_PDO_Test_Common.php b/spec/INTER-Mediator-UnitTest/DB-PDO/DB_PDO_Test_Common.php
@@ -216,6 +216,9 @@ public function testCreateRecord2()
         $this->db_proxy->requireUpdatedRecord(true);
         $newKeyValue = $this->db_proxy->createInDB();
 
+        // echo " Returns {$newKeyValue}\n";
+        //var_export($this->db_proxy->logger->getDebugMessages());
+
         $this->assertTrue($newKeyValue == -999, "Record wasn't created.");
         $createdRecord = $this->db_proxy->getUpdatedRecord();
         $this->assertNull($createdRecord, "Record wasn't created.");

diff --git a/src/php/DB/PDO.php b/src/php/DB/PDO.php
@@ -725,7 +725,7 @@ public function createInDB(bool $isReplace = false): ?string
         }
         $seqObject = $tableInfo['sequence'] ?? "{$this->dbSettings->getEntityForUpdate()}_{$keyField}_seq";
         $lastKeyValue = $this->handler->lastInsertIdAlt($seqObject, $tableNameRow); // $this->link->lastInsertId($seqObject);
-        if (/* $isReplace && */ $lastKeyValue === 0) { // lastInsertId returns 0 after replace command.
+        if (/* $isReplace && */ !$lastKeyValue) { // lastInsertId returns 0 after replace command.
             // Moreover, about MySQL, it returns 0 with the key field without AUTO_INCREMENT.
             $lastKeyValue = -999; // This means kind of error, so avoid to set non-zero value.
         }

diff --git a/src/php/DB/Support/DB_PDO_Handler.php b/src/php/DB/Support/DB_PDO_Handler.php
@@ -17,6 +17,7 @@
 namespace INTERMediator\DB\Support;
 
 use Exception;
+use INTERMediator\DB\Logger;
 use INTERMediator\DB\PDO;
 
 /**

diff --git a/src/php/DB/Support/DB_PDO_SQLite_Handler.php b/src/php/DB/Support/DB_PDO_SQLite_Handler.php
@@ -149,7 +149,7 @@ public function dateResetForNotNull(): string
      */
     protected function checkNullableField(string $info): bool
     {
-        return $info === 0;
+        return intval($info) === 0;
     }
 
     /**