Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build angleproject for mingw32 and clang32 #19747

Closed
kasper93 opened this issue Jan 13, 2024 · 4 comments
Closed

Build angleproject for mingw32 and clang32 #19747

kasper93 opened this issue Jan 13, 2024 · 4 comments

Comments

@kasper93
Copy link
Contributor

kasper93 commented Jan 13, 2024

Package name

angleproject

For which environment do you need the package?

CLANG32

Provide a brief description why you need this package in the selected environment

It has been removed in fff2fa3 without explaining why is has been disabled.

I would like to have build coverage for 32-bit builds too for mpv, which unfortunately due this removal was disabled for all the build targets now see mpv-player/mpv@d56ad8f

Are you willing to submit a PR?

No response

@Biswa96
Copy link
Member

Biswa96 commented Jan 13, 2024

Could you kindly provide some clarification on your requirement for 32-bit packages? Are you utilizing a 32-bit machine or a Windows operating system?

@Biswa96
Copy link
Member

Biswa96 commented Jan 13, 2024

Please see this #19326 discussion and this news https://www.msys2.org/news/#2023-12-13-starting-to-drop-some-32-bit-packages

@kasper93
Copy link
Contributor Author

Ok, in this case should we disable 32-bit CI in mpv? I don't see a sane path forward if packages can be randomly dropped. I don't need 32-bit build specifically. It increases test coverage of build test, as there were multiple issues in the past that were identified. But if it is no longer supported target by MSYS2, I don't think we should support it either.

kasper93 added a commit to kasper93/mpv that referenced this issue Jan 13, 2024
While mpv can be build for 32-bit platforms, MSYS started dropping some
of the 32-bit packages [1]. We cannot be asked to monitor and fix CI build
each time a dependency package randomly disappears [2].

Disable MSYS 32-bit builds if the support for this platforms is phased
out upstream. Sadly this will reduce our build coverage.

[1] https://www.msys2.org/news/#2023-12-13-starting-to-drop-some-32-bit-packages
[2] msys2/MINGW-packages@fff2fa3

See also: msys2/MINGW-packages#19747
kasper93 added a commit to kasper93/mpv that referenced this issue Jan 13, 2024
While mpv can be build for 32-bit platforms, MSYS started dropping some
of the 32-bit packages [1]. We cannot be asked to monitor and fix CI build
each time a dependency package randomly disappears [2].

Disable MSYS 32-bit builds if the support for this platforms is phased
out upstream. Sadly this will reduce our build coverage.

[1] https://www.msys2.org/news/#2023-12-13-starting-to-drop-some-32-bit-packages
[2] msys2/MINGW-packages@fff2fa3

See also: msys2/MINGW-packages#19747
@kasper93
Copy link
Contributor Author

kasper93 commented Jan 13, 2024

I decided to remove 32-bit builds of mpv from our CI. mpv-player/mpv#13277

If it is intended to remove 32-bit packages randomly like that it is not feasible to maintain those builds and fix them each time something disappears.

sfan5 pushed a commit to mpv-player/mpv that referenced this issue Jan 14, 2024
While mpv can be build for 32-bit platforms, MSYS started dropping some
of the 32-bit packages [1]. We cannot be asked to monitor and fix CI build
each time a dependency package randomly disappears [2].

Disable MSYS 32-bit builds if the support for this platforms is phased
out upstream. Sadly this will reduce our build coverage.

[1] https://www.msys2.org/news/#2023-12-13-starting-to-drop-some-32-bit-packages
[2] msys2/MINGW-packages@fff2fa3

See also: msys2/MINGW-packages#19747
xrun1 pushed a commit to xrun1/mpv-svp-fix that referenced this issue Mar 12, 2024
While mpv can be build for 32-bit platforms, MSYS started dropping some
of the 32-bit packages [1]. We cannot be asked to monitor and fix CI build
each time a dependency package randomly disappears [2].

Disable MSYS 32-bit builds if the support for this platforms is phased
out upstream. Sadly this will reduce our build coverage.

[1] https://www.msys2.org/news/#2023-12-13-starting-to-drop-some-32-bit-packages
[2] msys2/MINGW-packages@fff2fa3

See also: msys2/MINGW-packages#19747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants