Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiconthemes: KIconTheme needs to add BreezeIcons as build-time dependency and needs to be patched for init icon resources correctly #20687

Open
2 of 7 tasks
BLumia opened this issue Apr 20, 2024 · 3 comments
Labels

Comments

@BLumia
Copy link
Contributor

BLumia commented Apr 20, 2024

Description / Steps to reproduce the issue

There are two issues:

  1. It's suggested to build KIconTheme with BreezeIcons since icon theme works in a different way under Windows. when adding BreezeIcons as a build-time dependency, KIconTheme will help init icon resources and ensure app also find icons from Qt's resource system, so programs can use BreezeIcons as they do under Linux.
  2. KIconTheme's 6.1.0 release has a typo: KDE/kiconthemes@d8ee0ca which will cause the icon resource not be able to init correctly. KDE applied a patch to fix this issue from their build system (Craft), see https://github.com/KDE/craft-blueprints-kde/blob/9335df8a24b10043295086e8079909736f551627/kde/frameworks/tier3/kiconthemes/kiconthemes-6.1.0-20240415.diff

And another issue I haven't figure it out right now:

Expected behavior

kiconthemes is build with BreezeIcons and patched, so KDE apps like Kate can find breeze icons, as lone as they are depend on kiconthemes.

Actual behavior

kiconthemes (currently ucrt64/mingw-w64-ucrt-x86_64-kiconthemes 6.1.0-1) is not build with BreezeIcons and not patched.

Verification

Windows Version

MINGW64_NT-10.0-22631

MINGW environments affected

  • MINGW64
  • MINGW32
  • UCRT64
  • CLANG64
  • CLANG32
  • CLANGARM64

Are you willing to submit a PR?

Maybe? But might not have time to submit this as a patch right now. Feel free to work on it directly if you plan to do so, and please leave a comment first before you work on this issue.

@BLumia BLumia added the bug label Apr 20, 2024
@Biswa96
Copy link
Member

Biswa96 commented Apr 20, 2024

breeze and breeze-icons are incomplete right now because the source tarball contain symlinks. craft uses some wizardry to copy files, see https://invent.kde.org/packaging/craft/-/blob/bfac5fa33be1ae8a4be2e9a9446a9aa05fc103fc/bin/utils.py#L153-153. I need some help to fix those first.

@BLumia
Copy link
Contributor Author

BLumia commented Apr 21, 2024

breeze and breeze-icons are incomplete right now

Is there a related issue so I can check the details?

I need some help to fix those first.

I'm interested in helping (no promise tho, since my spare time is quite limited recently), but is that issue blocking this issue from fixed? If not, I personally tend to fix this issue first when I got time, then try the symlink one.

@BLumia
Copy link
Contributor Author

BLumia commented Apr 24, 2024

breeze and breeze-icons are incomplete right now

Is there a related issue so I can check the details?

Additionally, I actually didn't even notice the missing icon issue. KDE apps on Windows actually use the BreezeIcon assets embedded in the resource file instead of using the one on-disk. Do you have related screenshots (or other info/resources) to showcase this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants