Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump glib to 2.69.0? #9154

Closed
Jehan opened this issue Jul 16, 2021 · 2 comments · Fixed by #9158
Closed

Bump glib to 2.69.0? #9154

Jehan opened this issue Jul 16, 2021 · 2 comments · Fixed by #9158

Comments

@Jehan
Copy link

Jehan commented Jul 16, 2021

Hi!

Just a small report to raise attention to the existence of glib 2.69.0.

This version brings a huuuge improvement in glib for Windows, which is getting rid of some usage of win32 API which could make an application hang for a long time (I am talking up to minutes, if not a dozen of minutes, according to what some people reported in GIMP, when opening file dialogs).

The corresponding fix is in 2.69.0 but not in any 2.68.x.

Alternatively (if for some reason 2.69.0 brings issues), you can build 2.68.x with patches from https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2020

It's fine too!
Thanks. 🙂

@lazka
Copy link
Member

lazka commented Jul 16, 2021

backporting the patch is definitely preferred. 2.69 is just a development release

lazka added a commit to lazka/MINGW-packages that referenced this issue Jul 17, 2021
@Jehan
Copy link
Author

Jehan commented Jul 17, 2021

Thanks!

gnomesysadmins pushed a commit to GNOME/gimp that referenced this issue Aug 22, 2021
We were building it to add the patch glib!2020, but it has now been
backported in MSYS2 package:
msys2/MINGW-packages#9154
This was about the most infamous bug #913 for very slow file dialogs on
Windows when some drives are disconnected, or with slow/non-accessible
network drives or even fake floppy drives created in the Bios.

Similarly we also wanted glib!2205 and glib!2210 for bug #6780 about
GIMP crashing unexpectedly when images are opened in other (apparently
unrelated applications). I had not updated our build scripts yet, but
anyway, it got backport to the MSYS2 package first, then even to GLib
2.68.4 which has been recently released (and bumped in MSYS2 as well).
See: msys2/MINGW-packages#9283

So let's rely again on MSYS2 package!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants