Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.9.7: failed to build _decimal module #9645

Closed
jeremyd2019 opened this issue Sep 23, 2021 · 2 comments · Fixed by #9646
Closed

python 3.9.7: failed to build _decimal module #9645

jeremyd2019 opened this issue Sep 23, 2021 · 2 comments · Fixed by #9646

Comments

@jeremyd2019
Copy link
Member

jeremyd2019 commented Sep 23, 2021

I noticed this while clangarm64 was building python 3.9.7, but looking back at the autobuild logs this failed on ucrt64 too at least:

  In file included from ../Python-3.9.7/Include/unicodeobject.h:58,
                   from ../Python-3.9.7/Include/Python.h:106,
                   from C:/_/M/mingw-w64-python/src/Python-3.9.7/Modules/_decimal/_decimal.c:29:
  C:/_/M/mingw-w64-python/src/Python-3.9.7/Modules/_decimal/_decimal.c: In function 'dec_format':
  C:/_/M/mingw-w64-python/src/Python-3.9.7/Modules/_decimal/_decimal.c:3282:43: error: 'uchar' undeclared (first use in this function); did you mean 'char'?
   3282 |         if (n > 1 || (n == 1 && !isascii((uchar)spec.dot[0]))) {
        |                                           ^~~~~

Python doesn't fail the build if a module fails, it just lacks that module, so this was probably overlooked.

@jeremyd2019
Copy link
Member Author

Same error in mingw64, so probably failed everywhere.

@lazka
Copy link
Member

lazka commented Sep 23, 2021

This code is changed in 3.10 upstream: python/cpython#24962

lazka added a commit to lazka/MINGW-packages that referenced this issue Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants