Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated drmingw to 0.9.5 #11977

Merged
merged 3 commits into from
Jul 3, 2022
Merged

Updated drmingw to 0.9.5 #11977

merged 3 commits into from
Jul 3, 2022

Conversation

hmartinez82
Copy link
Contributor

@hmartinez82 hmartinez82 commented Jul 1, 2022

Notes:

  • Removed unused patch
  • Renamed the first patch to have the 0001 prefix
  • The upstream repo now has two git submodules and they are not included in the .tar.gz file for the release so switching to git cloning the specific tag/release plus initializing the submodules was required.

@hmartinez82
Copy link
Contributor Author

hmartinez82 commented Jul 1, 2022

Investigating... the non CLANG failures

@kmilos
Copy link
Contributor

kmilos commented Jul 1, 2022

Would it be possible to debundle at least zlib? It's such a common system lib, and we should probably request something like the "USE_SYSTEM_ZLIB" CMake option upstream anyway...

I guess libdwarf must stay bundled until we package it for MSYS2 at some point.

@hmartinez82
Copy link
Contributor Author

@kmilos I've added the feature request jrfonseca/drmingw#69 . If/when they do it, I'll update the recipe here again

Nice catch. I didn't know we are supposed to rest the package release when we move to a new package version !

Co-authored-by: مهدي شينون (Mehdi Chinoune) <79349457+MehdiChinoune@users.noreply.github.com>
@lazka lazka merged commit 4126613 into msys2:master Jul 3, 2022
@hmartinez82 hmartinez82 deleted the drmingw_0_9_5 branch July 3, 2022 18:31
@asmwarrior
Copy link

Hi, drmingw 0.9.7 is released, and this release fixes a bug that a RPT can't be saved, see here: ExcHndl.dll can't print the crash call stack under Windows 7, can you update in msys2 packages? Thanks.

@MehdiChinoune
Copy link
Collaborator

Hi, drmingw 0.9.7 is released, and this release fixes a bug that a RPT can't be saved, see here: ExcHndl.dll can't print the crash call stack under Windows 7, can you update in msys2 packages? Thanks.

see: #13106
Although Windows 7 will be dropped soon #10088

@asmwarrior
Copy link

Hi, that issue title(mention Windows 7) is misleading, because I use Windows 7. But the actual fix is in a file path handling code, so it is not specific to Windows 7.

See the actual code here:

exchndl: Fix path truncation. · jrfonseca/drmingw@d64a9c7

@asmwarrior
Copy link

Hi, drmingw 0.9.7 is released, and this release fixes a bug that a RPT can't be saved, see here: ExcHndl.dll can't print the crash call stack under Windows 7, can you update in msys2 packages? Thanks.

see: #13106 Although Windows 7 will be dropped soon #10088

Thanks for your pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants