Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fortran-stdlib PKGBUILD #16957

Merged
merged 2 commits into from Apr 26, 2023
Merged

Add Fortran-stdlib PKGBUILD #16957

merged 2 commits into from Apr 26, 2023

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented Apr 25, 2023 •
edited

Fortran-stdlib is a community standard library for fortran-lang.

  1. clang32, clang64, and clangarm64 are not supported because they do not have gfortran.
  2. Currently ming64-w64-python-fypp is invalid due to a unknown bug, so this PR uses pip to install fypp.

@Biswa96
Copy link
Member

Biswa96 commented Apr 25, 2023

Currently ming64-w64-python-fypp is invalid due to a unknown bug, so this PR uses pip to install fypp.

The package should depend on the mingw python fypp.

@Biswa96 Biswa96 added the new-package Pull request which adds new package(s) label Apr 25, 2023
@zoziha
Copy link
Contributor Author

zoziha commented Apr 25, 2023

I originally used ming64-w64-python-fypp (see commit), but CI failed, I think because of a problem with ming64-w64-python-fypp, I'm not sure if I can fix it.

@Biswa96
Copy link
Member

Biswa96 commented Apr 25, 2023

The issue is that the fypp-script.py file contains full path of python executable. So, I just ported it to use python-build. The python-fypp fix is in this pull request #16958. Please wait for it to be in queue.

@zoziha zoziha marked this pull request as draft April 26, 2023 02:05
@zoziha zoziha marked this pull request as ready for review April 26, 2023 02:51
@zoziha
Copy link
Contributor Author

zoziha commented Apr 26, 2023 •
edited

Thanks to the python-fypp fix, I rearranged PKGBUILD and it now uses python-fypp, CI as expected.

@Biswa96 , everything is ready to merge.

MehdiChinoune
MehdiChinoune reviewed Apr 26, 2023
View reviewed changes
mingw-w64-fortran-stdlib/PKGBUILD Outdated
"${MINGW_PACKAGE_PREFIX}-cmake"
"${MINGW_PACKAGE_PREFIX}-ninja"
"${MINGW_PACKAGE_PREFIX}-python-fypp")
options=('strip')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options=('strip')

It's the default

@MehdiChinoune
Copy link
Collaborator

Please fellow PKGBUILD-template.

@zoziha
Copy link
Contributor Author

zoziha commented Apr 26, 2023

Thank you for your review @MehdiChinoune . I have revised according to the comments, and read the template.

@Biswa96 Biswa96 merged commit e481f74 into msys2:master Apr 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MehdiChinoune MehdiChinoune MehdiChinoune left review comments

Assignees
No one assigned
Labels
new-package Pull request which adds new package(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zoziha @Biswa96 @MehdiChinoune