Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inih: enable static linking using pkgconf #19711

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Jan 11, 2024

No description provided.

@Biswa96
Copy link
Member

Biswa96 commented Jan 11, 2024

Please use a patch file and upstream the changes if possible.

@kmilos
Copy link
Contributor Author

kmilos commented Jan 11, 2024

Please use a patch file and upstream the changes if possible.

IMHO there's no point in upstreaming this particular workaround, as the "ideal" solution needs to address this in the projects's Meson recipe directly (reported upstream).

Unfortunately, it would seem Meson doesn't support setting Cflags.private in their .pc generator yet?

@Biswa96
Copy link
Member

Biswa96 commented Jan 11, 2024

Oh, I did not notice that the build system is meson.

@Biswa96 Biswa96 merged commit b5d6107 into msys2:master Jan 11, 2024
8 checks passed
@kmilos kmilos deleted the inih_pc_static branch January 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants