libobjc2: Add clang64 support #20024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The is a mistake, the import library should be named in gnustep/libobjc2#276, it should be if (MINGW)
set(CMAKE_IMPORT_LIBRARY_SUFFIX ".dll.a")
set(CMAKE_IMPORT_LIBRARY_PREFIX "lib")
set(CMAKE_LINK_LIBRARY_SUFFIX "")
set(CMAKE_SHARED_LIBRARY_PREFIX "")
set(CMAKE_OBJCXX_IMPLICIT_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
endif () |
qmfrederik
added a commit
to qmfrederik/libobjc2
that referenced
this pull request
Feb 12, 2024
- Use "lib{library}.dll.a" for import libraries
- Use "{library.dll}" for shared libraries
See msys2/MINGW-packages#20024 (comment)
|
Thanks @MehdiChinoune , I submitted a patch for upstream and included it in this PR. With this, we now have: /mingw64/lib/libobjc.dll.a Is this what you were expecting? |
ognevny
reviewed
Feb 12, 2024
|
@qmfrederik could you try cmake from #20028 |
qmfrederik
added a commit
to gnustep/libobjc2
that referenced
this pull request
Feb 13, 2024
We no longer need to manually set these suffixes/prefixes as CMake in MSYS2 now knows about Objective C. See msys2/MINGW-packages#20028 See https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9244 See msys2/MINGW-packages#20024 (comment)
|
@MehdiChinoune Thank you for all your help. The libobjc2 patch got merged and I updated PKGBUILD to use the merged version of that patch. The installed files are now: which I believe is what we want. |
|
The name of dll was changed, so I think all reverse-dependencies should be rebuilt. |
Upstream libobjc2 now has clang64 support (via gnustep/libobjc2#276). Cherry-pick that commit and add clang64 to the build matrix for libobjc2. This cherry-picked commit also fixes the ".dll.a" suffix for library objects.
qmfrederik
force-pushed
the
libobjc2-clang64
branch
from
80bd572
to
3d982e7
Compare
qmfrederik
added a commit
to gnustep/libobjc2
that referenced
this pull request
Mar 21, 2024
We no longer need to manually set these suffixes/prefixes as CMake in MSYS2 now knows about Objective C. See msys2/MINGW-packages#20028 See https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9244 See msys2/MINGW-packages#20024 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream libobjc2 now has clang64 support (via gnustep/libobjc2#276).
Cherry-pick that commit and add clang64 to the build matrix for libobjc2. This cherry-picked commit also fixes the ".dll.a" suffix for library objects, so we no longer need to manually rename that file.