Turn off default Windows error reporting by default #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In msys2#18, we discussed a change that would allow default Windows error handling of spawned processes to kick in (such as registered JIT debuggers). We even agreed that it would make sense to hide this functionality behind a flag, `winjitdebug`. However, when this got upstreamed as 21ec498 (cygwin: use CREATE_DEFAULT_ERROR_MODE in spawn, 2020-12-09), that flag was deemed unnecessary. But it would appear that it _is_ necessary: As reported in msys2/MSYS2-packages#2414 (comment) this new behavior is pretty disruptive e.g. in CI scenarios. So let's introduce that `winjitdebug` flag (settable via the environment variable `MSYS`) at long last. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I just verified that this fix works. |
|
lgtm |
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Mar 31, 2021
Unless `MSYS` contains `winjitdebug`, with this change we won't show that annoying message box e.g. when a DLL is missing. This is essentially forwarding msys2/msys2-runtime#35 to MSYS2-packages. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
atomlong
pushed a commit
to atomlong/MSYS2-packages
that referenced
this pull request
Apr 14, 2021
Unless `MSYS` contains `winjitdebug`, with this change we won't show that annoying message box e.g. when a DLL is missing. This is essentially forwarding msys2/msys2-runtime#35 to MSYS2-packages. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in msys2/MSYS2-packages#2414 (comment), v3.2.0 of the Cygwin runtime has a pretty disruptive new behavior where it shows a message box e.g. when a DLL is missing (it used to write that error message to
stderrinstead).Let's reinstate the old behavior, allowing to opt-in to the new behavior (which is desired e.g. when debugging using a registered JIT debugger) via the
winjitdebugflag in the environment variableMSYS.This implements what we talked about here, at long last.
Cc: @lazka @jeremyd2019