Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

vim/gvim Better syntax color highlighting #59

Closed
mcandre opened this issue Feb 19, 2013 · 5 comments
Closed

vim/gvim Better syntax color highlighting #59

mcandre opened this issue Feb 19, 2013 · 5 comments

Comments

@mcandre
Copy link

mcandre commented Feb 19, 2013

Color highlighting is supported in gVim, a standalone port of vim for Windows. Could we improve syntax highlighting in msysgit vim? It's as easy as copying over the syntax/ directory from a gVim installation into the msysgit vim directory, so providing better syntax highlighting by default in fresh msysgit installations should be easy. :) I've set mine to molokai.

http://superuser.com/questions/213295/enable-syntax-highlighting-on-msysgits-version-of-vim/409764#409764

@kusma
Copy link
Member

kusma commented Feb 19, 2013

Huh, I have syntax-highlighting working just fine in my msysGit installation... Perhaps you're referring to Git for Windows (which I do not know if we ship the syntax files with or not) instead?

However, I would be somewhat worried about trying to turn the Git for Windows distribution into a fully fledged development environment, so I don't think such a feature would get my vote. We already have msysGit for that.

@dscho
Copy link
Member

dscho commented Feb 19, 2013

It works for me, too. Looking at /share/WinGit/copy-files.sh, I see that all the relevant syntax files are copied over to Git for Windows, too. I suggest the OP might want to try again after installing the current Git for Windows from scratch.

@mcandre
Copy link
Author

mcandre commented Feb 19, 2013

I used the official Git Windows download from git-scm.com.

Specifically, I'm using both gVim vim and msysgit vim, and I had to do a lot of debugging to get a simple color scheme (molokai.vim) to work for Command Prompt "vim" and Git Bash "vim".

On Stack Overflow, users are reporting that copying over the syntax folder from the gVim installation directory to the Git vim installation directory fixes highlighting issues.

This fix works on my machine, so I was thinking that maybe we should include these same files by default in new Git Windows installations.

@dscho
Copy link
Member

dscho commented Feb 19, 2013

@mcandre while I appreciate the wishes of many users, keep in mind that we worked very hard to keep the installer as small as it is. Yes, it is not very small, but that is in spite of us trying to block feature creep.

So maybe the best idea would be to make it easy for users to download the syntax folder via GitHub? Maybe download a .zip of just that directory as per 'master', GitHub has such a link, I am sure. It could be done easily as a shell script, and it would even be possible to have a checkbox (unchecked by default, of course) in the installer.

@mcandre how about giving it a try?

@mcandre
Copy link
Author

mcandre commented Feb 19, 2013

Yes, I love minimalistic programs, and I respect BusyBox's mission.

I am confident that I could copy over the files to BusyBox's vi directory
manually and aid in scripting a downloadable feature, except that I'm not
sure on my Android phone where that would be. /system/... ? /data/... ?

On Tue, Feb 19, 2013 at 10:33 AM, dscho notifications@github.com wrote:

@mcandre https://github.com/mcandre while I appreciate the wishes of
many users, keep in mind that we worked very hard to keep the installer as
small as it is. Yes, it is not very small, but that is in spite of us
trying to block feature creep.

So maybe the best idea would be to make it easy for users to download the
syntax folder via GitHub? Maybe download a .zip of just that directory as
per 'master', GitHub has such a link, I am sure. It could be done easily as
a shell script, and it would even be possible to have a checkbox (unchecked
by default, of course) in the installer.

@mcandre https://github.com/mcandre how about giving it a try?


Reply to this email directly or view it on GitHubhttps://github.com//issues/59#issuecomment-13778375.

Cheers,

Andrew Pennebaker
www.yellosoft.us

@dscho dscho closed this as completed Dec 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants