This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
forked from kubernetes-retired/service-catalog
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace changevalidator with webhook (#14)
- Loading branch information
1 parent
3e9a872
commit f6cda00
Showing
16 changed files
with
976 additions
and
7 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
pkg/webhook/servicecatalog/serviceinstance/validation/handler.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| Copyright 2019 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package validation | ||
|
|
||
| import ( | ||
| "context" | ||
| "net/http" | ||
|
|
||
| sc "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog/v1beta1" | ||
| "github.com/kubernetes-incubator/service-catalog/pkg/webhookutil" | ||
|
|
||
| "github.com/hashicorp/go-multierror" | ||
| admissionTypes "k8s.io/api/admission/v1beta1" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/runtime/inject" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook/admission" | ||
| ) | ||
|
|
||
| // Validator is used to implement new validation logic | ||
| type Validator interface { | ||
| Validate(context.Context, admission.Request, *sc.ServiceInstance, *webhookutil.TracedLogger) error | ||
| } | ||
|
|
||
| // AdmissionHandler handles ServiceInstance validation | ||
| type AdmissionHandler struct { | ||
| decoder *admission.Decoder | ||
| client client.Client | ||
|
|
||
| CreateValidators []Validator | ||
| UpdateValidators []Validator | ||
| } | ||
|
|
||
| var _ admission.Handler = &AdmissionHandler{} | ||
| var _ admission.DecoderInjector = &AdmissionHandler{} | ||
| var _ inject.Client = &AdmissionHandler{} | ||
|
|
||
| // NewAdmissionHandler creates new AdmissionHandler and initializes validators list | ||
| func NewAdmissionHandler() *AdmissionHandler { | ||
| return &AdmissionHandler{ | ||
| UpdateValidators: []Validator{&DenyPlanChangeIfNotUpdatable{}}, | ||
| } | ||
| } | ||
|
|
||
| // Handle handles admission requests. | ||
| func (h *AdmissionHandler) Handle(ctx context.Context, req admission.Request) admission.Response { | ||
| traced := webhookutil.NewTracedLogger(req.UID) | ||
| traced.Infof("Start handling AdmissionHandler operation: %s for %s: %q", req.Operation, req.Kind.Kind, req.Name) | ||
|
|
||
| si := &sc.ServiceInstance{} | ||
| if err := webhookutil.MatchKinds(si, req.Kind); err != nil { | ||
| traced.Errorf("Error matching kinds: %v", err) | ||
| return admission.Errored(http.StatusBadRequest, err) | ||
| } | ||
|
|
||
| if err := h.decoder.Decode(req, si); err != nil { | ||
| traced.Errorf("Could not decode request object: %v", err) | ||
| return admission.Errored(http.StatusBadRequest, err) | ||
| } | ||
|
|
||
| var errs error | ||
|
|
||
| switch req.Operation { | ||
| case admissionTypes.Create: | ||
| for _, v := range h.CreateValidators { | ||
| if err := v.Validate(ctx, req, si, traced); err != nil { | ||
| errs = multierror.Append(errs, err) | ||
| } | ||
| } | ||
| case admissionTypes.Update: | ||
| for _, v := range h.UpdateValidators { | ||
| if err := v.Validate(ctx, req, si, traced); err != nil { | ||
| errs = multierror.Append(errs, err) | ||
| } | ||
| } | ||
| default: | ||
| traced.Infof("ServiceInstance AdmissionHandler wehbook does not support action %q", req.Operation) | ||
| return admission.Allowed("action not taken") | ||
| } | ||
|
|
||
| if errs != nil { | ||
| return admission.Denied(errs.Error()) | ||
| } | ||
|
|
||
| traced.Infof("Completed successfully AdmissionHandler operation: %s for %s: %q", req.Operation, req.Kind.Kind, req.Name) | ||
| return admission.Allowed("ServiceInstance AdmissionHandler successful") | ||
| } | ||
|
|
||
| // InjectDecoder injects the decoder into the handlers | ||
| func (h *AdmissionHandler) InjectDecoder(d *admission.Decoder) error { | ||
| h.decoder = d | ||
|
|
||
| for _, v := range h.CreateValidators { | ||
| admission.InjectDecoderInto(d, v) | ||
| } | ||
| for _, v := range h.UpdateValidators { | ||
| admission.InjectDecoderInto(d, v) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // InjectClient injects the client into the handlers | ||
| func (h *AdmissionHandler) InjectClient(c client.Client) error { | ||
| h.client = c | ||
|
|
||
| for _, v := range h.CreateValidators { | ||
| inject.ClientInto(c, v) | ||
| } | ||
| for _, v := range h.UpdateValidators { | ||
| inject.ClientInto(c, v) | ||
| } | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.