Fix travelnet removal issue and cleanup removal code #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually... if the data doesn't exist, maybe we do want to remove the node without updating the data... |
S-S-X
reviewed
Aug 20, 2022
|
Tested and works as expected 👍 |
waxtatect
added a commit
to waxtatect/travelnet
that referenced
this pull request
Aug 22, 2022
translations as po files from unmerged PRs: mt-mods#52, mt-mods#58 and mt-mods#41 in https://github.com/Sokomine/travelnet converted to tr files manually with regex
wsor4035
pushed a commit
that referenced
this pull request
Aug 26, 2022
* add fr, it and pl translations translations as po files from unmerged PRs: #52, #58 and #41 in https://github.com/Sokomine/travelnet converted to tr files manually with regex * update translations generated using https://github.com/minetest-tools/update_translations * clean unused strings and manual fixes * typos and missing translations * generate the translations... again with the script some small fixes too * more fixes descriptions defined in travelnet.node_description are translated but not found by the script * let's do this add S() to travelnet.node_description directly, remove part of changes in 833c5a3 * one more string travelnet have this field filled with the player name * consistency with "Travelnet-Box" already taken in account by most translations, missed the template in the previous commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
The issue here was that after this MR #56 I accidentally changed one instance of
"owner"to"owner_name"that was referring to metadata, not formspec fields. The error was made because the metadata is serialised, so is a table with thefieldsproperty, I interpreted this as formspec fields instead of metadata so didn't correct it when reviewing the code.Incorrect. We want it to remove the station if the data is broken.
I've cleaned up the code a little as I noticed we don't technically detect all failures and may actually give a player an item when the removal actually fails.I split up the
travelnet.remove_boxmethod intotravelnet.remove_box_actionandtravelnet.remove_box_message, separating out the action lets us tell if it's succeeded or not before continuing. It also brings it closer in line with the high-level actions, which respond in the same way on failuretravelnet.remove_boxis kept, and simply calls into those new methods to replicate the old behaviour