Add client header option to requests #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's pretty good, @mazhead. Thanks for this change. Do you mind adding unit tests too? :) |
environ does not support dictionaries, so HEADER can't be passed.
|
@mtakaki added unit tests. Basically to just check if with header and without header the response is correct. I had to remove the os.environ for HEADER as it does not support dict. |
Repository owner
deleted a comment
Mar 21, 2019
|
Thanks again for this, @mazhead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would add client header option to the requests.
Would help in some particular cases where header is expected.
Note: The request headers needs to be a dictionary.
Feel free to modify if it does not fit your coding style.