Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused token from Configuration object #95

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Remove unused token from Configuration object #95

merged 1 commit into from
Apr 30, 2020

Conversation

nijel
Copy link
Contributor

@nijel nijel commented Apr 29, 2020

It is not used anywhere, Cachet is called through Client.

@nijel nijel marked this pull request as ready for review April 29, 2020 07:59
It is not used anywhere, Cachet is called through Client.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 75.243% when pulling e05932b on nijel:configuration-token into 21063d6 on mtakaki:master.

@mtakaki
Copy link
Owner

mtakaki commented Apr 29, 2020

Codacy Here is an overview of what got changed by this pull request:

Coverage decreased per file
===========================
- cachet_url_monitor/configuration.py  -1
         

Complexity decreasing per file
==============================
+ tests/test_configuration.py  -1
         

See the complete overview on Codacy

@mtakaki
Copy link
Owner

mtakaki commented Apr 30, 2020

Looks great! Good catch!
Thank you so much!

@mtakaki mtakaki merged commit 5b9a356 into mtakaki:master Apr 30, 2020
@nijel nijel deleted the configuration-token branch April 30, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants