Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic webhooks #96

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Add support for generic webhooks #96

merged 1 commit into from
Apr 30, 2020

Conversation

nijel
Copy link
Contributor

@nijel nijel commented Apr 29, 2020

This can be useful with push notification services such as Gotify.

Built on top of #95

@coveralls
Copy link

coveralls commented Apr 29, 2020

Coverage Status

Coverage increased (+1.4%) to 76.667% when pulling d556c04 on nijel:webhooks into 5b9a356 on mtakaki:master.

Copy link
Owner

@mtakaki mtakaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thank you so much for the awesome work. I added a few comments.

cachet_url_monitor/configuration.py Outdated Show resolved Hide resolved
cachet_url_monitor/configuration.py Outdated Show resolved Hide resolved
cachet_url_monitor/webhook.py Show resolved Hide resolved
This can be useful with push notification services such as Gotify.
@mtakaki
Copy link
Owner

mtakaki commented Apr 30, 2020

Codacy Here is an overview of what got changed by this pull request:

Coverage increased per file
===========================
+ cachet_url_monitor/configuration.py  3
         

Coverage decreased per file
===========================
- cachet_url_monitor/scheduler.py  -2
         

Complexity increasing per file
==============================
- cachet_url_monitor/configuration.py  1
- cachet_url_monitor/webhook.py  2
         

See the complete overview on Codacy

@mtakaki
Copy link
Owner

mtakaki commented Apr 30, 2020

Thank you once again for this awesome contribution :)

@mtakaki mtakaki merged commit a92622a into mtakaki:master Apr 30, 2020
@nijel nijel deleted the webhooks branch April 30, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants