Implementing ACID Transactions #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Dec 27, 2023
yceruto
commented
Dec 27, 2023
src/BookStore/Infrastructure/Doctrine/DoctrineBookRepository.php
Outdated
Show resolved
Hide resolved
yceruto
force-pushed
the
acid_transactions
branch
from
0c151cb
to
27b7bbe
Compare
chalasr
previously approved these changes
Dec 27, 2023
chalasr
dismissed
their stale review
Some tests seem broken with this change
yceruto
force-pushed
the
acid_transactions
branch
5 times, most recently
from
8178d72
to
01456c6
Compare
Yeah, still checking |
yceruto
force-pushed
the
acid_transactions
branch
3 times, most recently
from
44a641a
to
5cfab63
Compare
This comment was marked as outdated.
This comment was marked as outdated.
yceruto
force-pushed
the
acid_transactions
branch
from
5cfab63
to
04990c2
Compare
yceruto
force-pushed
the
acid_transactions
branch
from
04990c2
to
4a3ab51
Compare
|
I added a |
mtarld
reviewed
Dec 28, 2023
yceruto
force-pushed
the
acid_transactions
branch
from
2de379e
to
96a6132
Compare
mtarld
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46
Introduces ACID (Atomicity, Consistency, Isolation, Durability) transactions, which are designed to improve data integrity and consistency. This enhancement involves the implementation of a new transaction management system using Doctrine Transaction Middleware within the Messenger component for command handlers.
This approach guarantees that once transactions are committed, they remain stable and unaffected by system failures.
I didn't check the tests yet...