Fred ros realinput #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want a clean C header file for those that use C/C++. The only reason we had void* was to make cython happy. Now all functions that take a void* make a cast and call the typed function. To keep things clean, we now have three headers. One for C users, one for python, and one with the typedefs that everyone needs. All headers end in .h, so they can be used from both C and C++. Not all tests pass on my machine. The failures are * test_rotix * test_loss * test_sample[SP_par1]
related to #37
Nothing is computed, the test just ensures that galario can used from C. This helped to fix a few problems and fixes #38.
* tests now compute the shift * Update readme on build types
galario.cpp: * conversion to complex with openmp and cuda kernel * save some redundancies * remove commented code * replace missing hard-coded nthreads per block libcommon.py: * uniform input checks test_galario.py: * pass real images where appropriate
real_to_complex_d() kernel had a wrong implementation for a 1d array, so that it was operating only the first nx elements, instead of nx*nx. Now I implemented the 2d kernel and works perfectly. All tests pass, both on CPU and GPU.
|
@fredRos |
added 2 commits
July 10, 2017 23:09
Only failure on 64 bit Debian 8
|
Thanks for the fix. I copied the code but that was for a 1D block. Should have known better. A few minor fixes and it's now in master finally |
This was referenced Jul 10, 2017
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the implementation of real_to_complex()