fix: routes not being considered in the correct order #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected
If you have the following routes defined:
/user/[id]/user/[id]/locationsThen a request to
/user/[id]/locationswill resolve to that, more specific, route.Actual
A request to
/user/[id]/locationsresolves to/user/[id]as it comes across this one first.Proposed change
This PR sorts the dynamic routes to have the longest routes first, which will ensure that, where routes are nested as such, the most specific route will be chosen.
Testing
Ideally I'd have extended tests to cover this case, but there aren't any and it feels outside of the scope of this change to add them. I've created an issue for this.