Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigTest Failing #21

Closed
codenamesubho opened this issue Feb 1, 2015 · 4 comments
Closed

ConfigTest Failing #21

codenamesubho opened this issue Feb 1, 2015 · 4 comments

Comments

@codenamesubho
Copy link
Contributor

I am trying to run test on Fedora 21 with gcc (GCC) 4.9.2. The Following test is failing:

Test name: ConfigTest::testMaxSize
equality assertion failed

  • Expected: 15360
  • Actual : 150

Failures !!!
Run: 201 Failure total: 1 Failures: 1 Errors: 0

@wsobel
Copy link
Member

wsobel commented Feb 1, 2015

this tests the logger file max size. it's a simple string parser, should not fail.

debug the test.

  • W

Sent from my iPad

On Feb 1, 2015, at 04:00, Subhendu Ghosh notifications@github.com wrote:

I am trying to run test on Fedora 21 with gcc (GCC) 4.9.2. The Following test is failing:

Test name: ConfigTest::testMaxSize
equality assertion failed

Expected: 15360
Actual : 150
Failures !!!
Run: 201 Failure total: 1 Failures: 1 Errors: 0


Reply to this email directly or view it on GitHub.

@codenamesubho
Copy link
Contributor Author

I tried debugging. Seems like the mConfig->loadConfig(logger) is not loading the config properly or having trouble flushing the old value. I tried changing the istringstream logger("logger_config {"max_size = 150\n"}\n"); max_size value. Despite different consecutive sizes of 15K , 15M , 15G It always tested with the first value set as max_size. So max_size is always 150. Therefore the first test for 150 passes but rest for 15K , 15M, 15G fails.

@wsobel
Copy link
Member

wsobel commented Feb 1, 2015

This is because of some experimental code I just added to monitor the config files and do a warm start if they change. I do not roll the logger on a warm start. This has nothing to do with fedora.

Change the test to create a new config object for each test. This will fix the issue.

This was a quick test I put in for a user to support auto agent configuration.

Sent from my iPhone

On Feb 1, 2015, at 11:16, Subhendu Ghosh notifications@github.com wrote:

I tried debugging. Seems like the mConfig->loadConfig(logger) is not loading the config properly or having trouble flushing the old value. I tried changing the istringstream logger("logger_config {"max_size = 150\n"}\n"); max_size value. Despite different consecutive sizes of 15K , 15M , 15G It always tested with the first value set as max_size. So max_size is always 150.


Reply to this email directly or view it on GitHub.

@wsobel
Copy link
Member

wsobel commented Feb 2, 2015

Fixed test and recreated agent configuration object each time.

@wsobel wsobel closed this as completed Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants