Implemented dynamic maxIterationCount for getRunDate() #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,10 @@ public function isSatisfiedBy(\DateTime $date, $value) | |||
| $tdate = clone $date; | |||
| $tdate->setDate($currentYear, $currentMonth, $lastDayOfMonth); | |||
| while ($tdate->format('w') != $weekday) { | |||
| $tdate->setDate($currentYear, $currentMonth, --$lastDayOfMonth); | |||
| $tdateClone = new \DateTime(); | |||
There was a problem hiding this comment.
For some reason the day of $tdate stays the same when using setDate();. This leads to an infinite loop since $tdate->format('w') is unchanged. This is not the most beautiful workaround, but it works.
There was a problem hiding this comment.
I don't think this change belongs in this PR. Can you remove it please?
tobias-kuendig
force-pushed
the
master
branch
from
5fbc9a5
to
63328b5
Compare
|
I have reverted the changes. |
| @@ -275,6 +275,21 @@ public function testProvidesMultipleRunDates() | |||
| new DateTime('2008-11-09 00:04:00'), | |||
| new DateTime('2008-11-09 00:06:00') | |||
| ), $cron->getMultipleRunDates(4, '2008-11-09 00:00:00', false, true)); | |||
|
|
|||
| // Fails with the default 1000 iteration limit | |||
| $cron = CronExpression::factory('0 0 12 1 * */2'); | |||
There was a problem hiding this comment.
Can you break this out into it's own test?
|
@dragonmantank I have moved the code to a separate test. |
dragonmantank
added a commit
that referenced
this pull request
Jan 26, 2016
Implemented dynamic maxIterationCount for getRunDate()
loneregister
pushed a commit
to loneregister/cron-expression
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a
maxIterationCountproperty that is used as the limit to bail on an impossible date ingetRunDate().When generating run dates that lie further in the future, the hard coded 1000 iterations aren't always enough (see Issue #66).
To work around this, you can now set the
maxIterationCountvia the setter methodsetMaxIterationCount.