Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix research grant to work with team sponsorship #4016

Merged
merged 1 commit into from Feb 9, 2019

Conversation

ChooJeremy
Copy link
Contributor

Fixes #3390

Fixes as suggested by @nealterrell in the original issue.

Basically moves the requirement to when the effect triggers (So the effect will always fire, but only ends up resolving if the trigger works) and adds interactive so that the user gets to order them manually, instead of the game ordering it manually.

The way the simultaneous triggers work become obvious if there are 2 copies of team sponsorship rezzed, in which case the first trigger adds Research's grants trigger to the simultaneous trigger selection but allows the user to pick between the 2nd team sponsorship's trigger and the research grant's trigger.

@NoahTheDuke
Copy link
Collaborator

NoahTheDuke commented Feb 3, 2019

Thanks for doing this! Glad you're tackling these forgotten bugs!

Would you mind writing a test making sure that you can score just one Research Grant without having a second installed? Seems that when I wrote the original test, I didn't account for that.

@NoahTheDuke
Copy link
Collaborator

I can get to the test another time.

@NoahTheDuke NoahTheDuke merged commit c390cf7 into mtgred:master Feb 9, 2019
@ChooJeremy
Copy link
Contributor Author

Thanks for doing this! Glad you're tackling these forgotten bugs!

Would you mind writing a test making sure that you can score just one Research Grant without having a second installed? Seems that when I wrote the original test, I didn't account for that.

@NoahTheDuke Oops, I somehow missed this message. I'll try writing one up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants