Adding ability to work with asynchronous tests #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
therealparmesh
force-pushed
the
async_mocha_tests
branch
3 times, most recently
from
f6e8eaf
to
e7b3d93
Compare
Closed
|
That's seems super cool. Thanks so much! Are you using some formatter like prettier? Because the diff is a bit hard to follow :) Also could you fix the conflict before I merge this :) |
|
I'm using Prettier which I have configured to adhere to ESLint. I'll clean up the diff and fix the conflict! Thank you! |
therealparmesh
force-pushed
the
async_mocha_tests
branch
from
e7b3d93
to
39ab6be
Compare
therealparmesh
changed the title
|
We're good to go! I rebased onto your updated FYI: The invalid peer dependency issue that I attempted to fix was already fixed in a separate pull request. This was why my pull request had merge conflicts. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Mocha's documentation on testing asynchronous code for the detailed description behind what I implemented here. Please let me know your thoughts on this!