Skip to content

Commit

Permalink
tg3: ethtool phys_id default
Browse files Browse the repository at this point in the history
When asked to blink LEDs the tg3 driver behaves when using:
	ethtool -p ethX
The default value for data is zero, and other drivers interpret this
as blink forever (or at least a really long time).  The tg3 driver
interprets this as blink once.  All drivers should have the same
behaviour.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and davem330 committed Feb 24, 2008
1 parent c73b1d1 commit 759afc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/tg3.c
Original file line number Diff line number Diff line change
Expand Up @@ -8781,7 +8781,7 @@ static int tg3_phys_id(struct net_device *dev, u32 data)
return -EAGAIN;

if (data == 0)
data = 2;
data = UINT_MAX / 2;

for (i = 0; i < (data * 2); i++) {
if ((i % 2) == 0)
Expand Down

0 comments on commit 759afc3

Please sign in to comment.