Skip to content

Commit

Permalink
MIPS: Fix __vmalloc() etc. on MIPS for non-GPL modules
Browse files Browse the repository at this point in the history
Commit b3594a089f1c17ff919f8f78505c3f20e1f6f8ce (lmo) rsp.
3513369 (kernel.org) break non-GPL modules
that use __vmalloc() or any of the vmap(), vm_map_ram(), etc functions on
MIPS.

All those functions are EXPORT_SYMBOL() so are meant to be allowed to be
used by non-GPL kernel modules.  These calls all take page protection as
an argument which is normally a constant like PAGE_KERNEL.

This commit causes all protection constants like PAGE_KERNEL to not be
constants and instead to contain the GPL-only symbol _page_cachable_default.

This means that all calls to __vmalloc(), vmap(), etc, cause non-GPL
modules to fail to link with the complaint that they are trying to use the
GPL-only symbol _page_cachable_default...

Change EXPORT_SYMBOL_GPL(_page_cachable_default) to EXPORT_SYMBOL() for
non-GPL modules that call __vmalloc(), vmap(), vm_map_ram() etc.

Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
Cc: Chris Dearman <chris@mips.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: http://patchwork.linux-mips.org/patch/1084/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Anton Altaparmakov authored and ralfbaechle committed Apr 12, 2010
1 parent 3d45285 commit 7b3e543
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/mips/mm/cache.c
Expand Up @@ -133,7 +133,7 @@ void __update_cache(struct vm_area_struct *vma, unsigned long address,
}

unsigned long _page_cachable_default;
EXPORT_SYMBOL_GPL(_page_cachable_default);
EXPORT_SYMBOL(_page_cachable_default);

static inline void setup_protection_map(void)
{
Expand Down

0 comments on commit 7b3e543

Please sign in to comment.