Increment diff counter in blockqute parsing (Fixes #37) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blockquote counter should be incremented when parsing quoted text, rather than set to the length of the quote. If there are multiple blockquotes in the text then the position counter must be tracked additively and cannot be assumed to start from zero each time. Thanks to @voku, who provided this patch. I've just grabbed his patch, and removed his local customisations for UTF8 versions of strlen.
|
Makes sense 👍 |
mtibben
added a commit
that referenced
this pull request
Oct 13, 2015
Increment diff counter in blockqute parsing (Fixes #37)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blockquote counter should be incremented when parsing quoted text,
rather than set to the length of the quote. If there are multiple
blockquotes in the text then the position counter must be tracked
additively and cannot be assumed to start from zero each time.
Thanks to @voku, who provided this patch. I've just grabbed his patch, and
removed his local customisations for UTF8 versions of strlen.