Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jinja2 to allow for Jinja2 3.x #51

Closed
whardier opened this issue May 20, 2021 · 3 comments
Closed

Bump Jinja2 to allow for Jinja2 3.x #51

whardier opened this issue May 20, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@whardier
Copy link

We have projects that depend on Jinja that also use this project and we are planning on using 3.x. It's a mess.. I know..

Please review new Jinja2 3.x for inclusion into this project. Alternatively I can help provide patching to remove Jinja2 from this project or possibly set Jinja2 as an extra dep since it is not required.

@whardier
Copy link
Author

#52

@mtkennerly
Copy link
Owner

Thanks for raising this concern. The timing here is kind of interesting:

  • poetry-dynamic-versioning still supports Python 3.5,
  • Jinja2 3.0.x no longer supports Python 3.5,
  • Poetry 1.1.x still supports Python 3.5, but 1.2.x will no longer support it (and there's already a 1.2.0a1 available, so it may not be long).

Fortunately, Poetry does allow you to configure different dependency ranges based on environment markers, so this is manageable.

As part of Poetry 1.2.0, the official plugin system will become available as well (#39), and then PDV and its dependencies might be installed in such a way that they wouldn't conflict with your project's use of a different Jinja2 version anyway (although I'm not 100% sure on that). Still, in the meantime, I agree it's best to update this.

@mtkennerly mtkennerly added the enhancement New feature or request label May 22, 2021
mtkennerly added a commit that referenced this issue May 26, 2021
@mtkennerly mtkennerly added this to the v0.13.0 milestone May 26, 2021
@mtkennerly
Copy link
Owner

This is now addressed in v0.13.0. Let me know if you run into any further issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants