Update to make jinja2 optional #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be easier to just broaden the jinja version spec
mtkennerly
requested changes
May 22, 2021
| @@ -26,7 +26,7 @@ include = ["zzz_poetry_dynamic_versioning.pth"] | |||
| python = "^3.5" | |||
| dunamai = "^1.5" | |||
| tomlkit = ">= 0.4" | |||
| jinja2 = "^2.11.1" | |||
| jinja2 = {version="^2.11.1", optional=true} | |||
There was a problem hiding this comment.
May be easier to just broaden the jinja version spec
Yeah, I'd rather do that for now, so that we don't have to change the install instructions now and then change them again in the near future for the official plugin system. I think we could do this:
jinja2 = [
{ version = "^2.11.1", python = "~3.5" },
{ version = "^3.0.0", python = "^3.6" },
]
|
I went ahead and released v0.13.0 with the broadened version range option. But thank you for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be easier to just broaden the jinja version spec
See: #51