Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --repo2 with --from-repo #114

Merged
merged 8 commits into from Jan 5, 2023
Merged

Replace --repo2 with --from-repo #114

merged 8 commits into from Jan 5, 2023

Conversation

worldworm
Copy link
Contributor

Hi there,

due to restic/restic#3742 --repo2 is deprecated.
I've added full support for --from-repo and --from-password-file. This should be completely backward compatible and repo2 still works (but give it a good test anyway).

Using repo2 will now print a warning like with restic:
grafik

I've added additional FIXME notes where you can remove code in your next major (breaking) release.

Unfortunately I was not successful in adjusting the e2e tests.
Changing this:
grafik

caused this:
grafik

It looks like something is flaky (or not cleaned up afterwards for another run). Or my dev setup is broken.

@mtlynch mtlynch changed the title replace --repo2 with --from-repo Replace --repo2 with --from-repo Jan 4, 2023
@mtlynch
Copy link
Owner

mtlynch commented Jan 4, 2023

Thanks for implementing this! I didn't know about these changes.

Can you purge repo2 and password_file2? Might as well delete them entirely and cut a breaking release now rather than drag them along.

@worldworm
Copy link
Contributor Author

I've removed the repo2 comand.
Thanks for the e2e tests 😃

@mtlynch
Copy link
Owner

mtlynch commented Jan 5, 2023

Thanks!

@mtlynch mtlynch merged commit c4b5e7f into mtlynch:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants