copy: replace --repo2 with --from-repo #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
from-repo
branch
from
4c57422
to
52e1981
Compare
`init` and `copy` use `--repo2` with two different meaning which has proven to be confusing for users. `--from-repo` now consistently marks a source repository from which data is read. `--repo` is now always the target/destination repository.
MichaelEischer
force-pushed
the
from-repo
branch
from
52e1981
to
2758d76
Compare
|
I've rebased the PR and added a changelog entry. So let's merge this. |
mtlynch
added a commit
to mtlynch/resticpy
that referenced
this pull request
Jan 5, 2023
Hi there, due to restic/restic#3742 --repo2 is deprecated. I've added full support for --from-repo and --from-password-file. This should be completely backward compatible and repo2 still works (but give it a good test anyway). Using repo2 will now print a warning like with restic:  I've added additional FIXME notes where you can remove code in your next major (breaking) release. Unfortunately I was not successful in adjusting the e2e tests. Changing this:  caused this:  It looks like something is flaky (or not cleaned up afterwards for another run). Or my dev setup is broken. Co-authored-by: Michael Lynch <git@mtlynch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
initandcopyuse--repo2with two different meaning which has proven to be confusing for users.--from-reponow consistently marks a source repository from which data is read.--repois now always the target/destination repository.The PR is already working, however, the parameter names still require discussion.
Was the change previously discussed in an issue or on the forum?
https://forum.restic.net/t/restic-repository2-confusion/5017
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.