Bug fix #12
Closed
Bug fix #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 We were bitten by this today - downgrading to 0.8.0 was a quick fix for us. |
|
I just hit this as well. |
|
Released 0.9.0 with a change that should fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db = GeoIP::City.new("GeoLiteCity.dat")
look_up = db.look_up("119.236.232.169")
Gives you a:
[BUG] Segmentation fault
Because region_name is empty for that IP. Those 2 commits fix that bug so that it returns an empty string. There are probably a better fix than returning an empty string but at least it fixes my problem.