Uncap pbr #173
Merged
Uncap pbr #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uncaps the pbr version. The PBR windows issue reported in: https://bugs.launchpad.net/pbr/+bug/1761134 no longer seems to effect the windows CI jobs. Since this is the only method we have to test functionality on windows this should be safe. If there are still configurations that this doesn't work on, they'll have to cap the PBR version downstream. The requirements.txt still sets a low minimum bound to enable doing this.
Merged
mtreinish
added a commit
that referenced
this pull request
May 31, 2018
Revert "Uncap pbr" Reverts #173 This was only a partial uncap as it was still capped in the setup.py for stestr. Meaning the passing tests were still using pbr<4.0.0. When you uncap the setup.py too, like in #174, things start failing again. The underlying issue hasn't been addressed yet so we can't uncap the requirement yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uncaps the pbr version now that the windows issue reported
in: https://bugs.launchpad.net/pbr/+bug/1761134 is fixed.