Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really uncap pbr #174

Merged
merged 1 commit into from Jun 5, 2018
Merged

Really uncap pbr #174

merged 1 commit into from Jun 5, 2018

Conversation

mtreinish
Copy link
Owner

The previous commit attempted to uncap pbr to see if the windows issue
was addressed. But neglected to do so in the setup.py cap in addition to
the requirements file. This commit corrects the oversight and uncaps
that too.

@mtreinish mtreinish mentioned this pull request May 31, 2018
@coveralls
Copy link

coveralls commented May 31, 2018

Coverage Status

Coverage remained the same at 64.785% when pulling 630af2f on really-uncap-pbr into 5ef3b46 on master.

mtreinish added a commit that referenced this pull request May 31, 2018
Revert "Uncap pbr"

Reverts #173

This was only a partial uncap as it was still capped in the setup.py for stestr. Meaning the passing tests were still using pbr<4.0.0. When you uncap the setup.py too, like in #174, things start failing again. The underlying issue hasn't been addressed yet so we can't uncap the requirement yet.
@mtreinish mtreinish changed the title Really uncap pbr WIP: Really uncap pbr May 31, 2018
@mtreinish
Copy link
Owner Author

This is a release blocker for 2.1.0, once we're able to uncap pbr we'll push the new release

The previous attempt to uncap pbr to see if the windows issue was
addressed neglected to do so in the setup.py cap in addition to
the requirements file. So it had to be reverted because it didn't really
@mtreinish mtreinish changed the title WIP: Really uncap pbr Really uncap pbr Jun 5, 2018
@mtreinish mtreinish merged commit 7d8f9ea into master Jun 5, 2018
@mtreinish mtreinish deleted the really-uncap-pbr branch June 5, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants