Fix #330 - Preserve load-list order #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `--load-list` to run tests the tests were always run in a different order than the one provided in the file, even when the `--random` argument was not present: $ stestr run --serial --load-list failing This patch preserves the order of the tests from the file when `--load-list` is used, and it will only randomize it when `--random` is provided: $ stestr run --serial --random --load-list failing
Akrog
changed the title
mtreinish
approved these changes
Aug 31, 2022
Comment on lines
+61
to
+74
| def _filter_tests(to_filter, id_map): | ||
| # Compatible objects | ||
| if extras.safe_hasattr(to_filter, 'filter_by_ids'): | ||
| res = to_filter.filter_by_ids(test_ids) | ||
| _filter_tests(res, id_map) | ||
| # TestCase objects. | ||
| elif extras.safe_hasattr(to_filter, 'id'): | ||
| test_id = to_filter.id() | ||
| if test_id in test_ids: | ||
| id_map[test_id] = to_filter | ||
| # Standard TestSuites or derived classes. | ||
| elif isinstance(to_filter, unittest.TestSuite): | ||
| for item in to_filter: | ||
| _filter_tests(item, id_map) |
There was a problem hiding this comment.
I'm a little uneasy about the recursion here. I feel like it probably would have been a bit cleaner to just do it iteratively. But it's not a big deal this should be fine. If it becomes an issue we can always refactor it later
mtreinish
added a commit
that referenced
this pull request
Sep 22, 2022
Several issues have been reported about the run order and other odd behavior in running of tests since the 4.0.0 release including a high degree of random failures in stestr CI. #331 is the only likely candidate as to the root cause. In the interest of fixing these issues for people this commit reverts #331. This reverts commit ff25c99.
mtreinish
added a commit
that referenced
this pull request
Sep 22, 2022
Several issues have been reported about the run order and other odd behavior in running of tests since the 4.0.0 release including a high degree of random failures in stestr CI. #331 is the only likely candidate as to the root cause. In the interest of fixing these issues for people this commit reverts #331. This revert was already released as part of 4.0.1. Since the main branch adopted `black` code formatting recently it was easier to do the straight revert on the stable branch first as there was conflicts. This reverts commit ff25c99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--load-listto run tests the tests were always run in a different order than the one provided in the file, even when the--randomargument was not present:This patch preserves the order of the tests from the file when
--load-listis used, and it will only randomize it when--randomis provided: