Fix filter by relationships #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahenzon
reviewed
Jan 11, 2024
mahenzon
reviewed
Jan 11, 2024
mahenzon
reviewed
Jan 15, 2024
| ), | ||
| [], | ||
| ) | ||
| for cast_type in [field.type_ for field in fields]: |
There was a problem hiding this comment.
мне кажется немного странным такое решение. почему бы не сделать так?
for field for field in fields:
cast_type = field.type_и отдельный вопрос: а мы тут casted_value перезаписываем каждый раз в цикле? не нужно куда-то сохранить полученное значение? или нам нужно только последнее? мб как-то прокомментировать в коде?
There was a problem hiding this comment.
почему бы не сделать так?
Да, так будет лучше
а мы тут casted_value перезаписываем каждый раз в цикле?
Это оригинальный подход, поведение которого я не менял. Звучит разумно останавливать цикл на первом успешном касте
CosmoV
force-pushed
the
fix-filter-by-relationships
branch
from
4984137
to
79fb3b0
Compare
CosmoV
force-pushed
the
fix-filter-by-relationships
branch
from
3aa1a60
to
3fae8f0
Compare
mahenzon
reviewed
Jan 17, 2024
mahenzon
reviewed
Jan 17, 2024
mahenzon
reviewed
Jan 17, 2024
mahenzon
reviewed
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.