Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/customizable request attributes #80

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

CosmoV
Copy link
Collaborator

@CosmoV CosmoV commented Mar 7, 2024

No description provided.

@CosmoV CosmoV requested a review from mahenzon March 7, 2024 06:06
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 95.57522% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 78.71%. Comparing base (7015aa1) to head (ebc59b5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   77.28%   78.71%   +1.42%     
==========================================
  Files          40       40              
  Lines        2457     2532      +75     
  Branches      359      374      +15     
==========================================
+ Hits         1899     1993      +94     
+ Misses        487      467      -20     
- Partials       71       72       +1     
Flag Coverage Δ
unittests 78.71% <95.57%> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
fastapi_jsonapi/views/detail_view.py 100.00% <100.00%> (ø)
fastapi_jsonapi/views/list_view.py 100.00% <100.00%> (ø)
fastapi_jsonapi/views/view_base.py 94.66% <100.00%> (ø)
fastapi_jsonapi/views/utils.py 98.70% <98.24%> (-1.30%) ⬇️
fastapi_jsonapi/querystring.py 84.50% <90.24%> (+16.81%) ⬆️

@mahenzon mahenzon merged commit 08d1f7f into main Mar 13, 2024
13 checks passed
@mahenzon mahenzon deleted the feature/customizable-request-attributes branch March 13, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants