Fix duplicate check

#267
mtth · Oct 26, 2019 · a36564c · a36564c
1 parent 45ac127
commit a36564c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -140,7 +140,7 @@ function objectValues(obj) {
  * @param fn {Function} Optional function to apply to each element.
  */
 function hasDuplicates(arr, fn) {
-  var obj = {};
+  var obj = Object.create(null);
   var i, l, elem;
   for (i = 0, l = arr.length; i < l; i++) {
     elem = arr[i];

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "avsc",
-  "version": "5.4.15",
+  "version": "5.4.16",
   "description": "Avro for JavaScript",
   "homepage": "https://github.com/mtth/avsc",
   "keywords": [

diff --git a/test/test_utils.js b/test/test_utils.js
@@ -18,6 +18,7 @@ suite('utils', function () {
     assert(utils.hasDuplicates([1, 3, 1]));
     assert(!utils.hasDuplicates([]));
     assert(!utils.hasDuplicates(['ab', 'cb']));
+    assert(!utils.hasDuplicates(['toString']));
     assert(utils.hasDuplicates(['ab', 'cb'], function (s) { return s[1]; }));
   });