Bug 2067708: Fix invalid-mapping check to allow mapping items by name…

… or id (kubev2v#961)
mturley · Jun 17, 2022 · 1c3bf03 · 1c3bf03
1 parent 99612fa
commit 1c3bf03
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/web/src/app/Mappings/components/helpers.ts b/pkg/web/src/app/Mappings/components/helpers.ts
@@ -124,6 +124,9 @@ export const useEditingMappingPrefillEffect = (
   return { isDonePrefilling };
 };
 
+export const doesSourceExist = (availableSources: MappingSource[], mappingItem: MappingItem) =>
+  !!getMappingSourceByRef(availableSources, mappingItem.source);
+
 export const doesTargetExist = (
   mappingType: MappingType,
   availableTargets: MappingTarget[],
@@ -148,6 +151,6 @@ export const isMappingValid = (
 ): boolean =>
   (mapping.spec.map as MappingItem[]).every(
     (mappingItem) =>
-      availableSources.some((source) => source.id === mappingItem.source.id) &&
+      doesSourceExist(availableSources, mappingItem) &&
       doesTargetExist(mappingType, availableTargets, mappingItem)
   );