master: fix SQLite asking for passwords. Closes #396

mtxr · Sep 28, 2019 · 14c00f3 · 14c00f3
1 parent b432e16
commit 14c00f3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/plugins/connection-manager/extension.ts b/packages/plugins/connection-manager/extension.ts
@@ -1,7 +1,7 @@
 import logger from '@sqltools/core/log/vscode';
 import ConfigManager from '@sqltools/core/config-manager';
 import { EXT_NAME } from '@sqltools/core/constants';
-import { ConnectionInterface } from '@sqltools/core/interface';
+import { ConnectionInterface, DatabaseDialect } from '@sqltools/core/interface';
 import getTableName from '@sqltools/core/utils/query/prefixed-tablenames';
 import SQLTools, { RequestHandler } from '@sqltools/core/plugin-api';
 import { getConnectionDescription, getConnectionId, isEmpty } from '@sqltools/core/utils';
@@ -41,7 +41,7 @@ export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin
   private ext_testConnection = async (c: ConnectionInterface) => {
     let password = null;
 
-    if (c.askForPassword) password = await this._askForPassword(c);
+    if (c.dialect !== DatabaseDialect.SQLite && c.askForPassword) password = await this._askForPassword(c);
     if (c.askForPassword && password === null) return;
     return this.client.sendRequest(
       TestConnectionRequest,

diff --git a/packages/ui/screens/Settings/Widget/ConnectionInfo.tsx b/packages/ui/screens/Settings/Widget/ConnectionInfo.tsx
@@ -50,7 +50,7 @@ const ConnectionInfo = ({ updateSettings, submit, toggleGlobal, testConnection,
           </button>
         </div>
       </form>
-      {<pre>{JSON.stringify(connectionSettings, null, 2)}</pre>}
+      {/* {<pre>{JSON.stringify(connectionSettings, null, 2)}</pre>} */}
       {/* {<pre>{JSON.stringify(errors, null, 2)}</pre>} */}
       {/* {<pre>{JSON.stringify(state, null, 2)}</pre>} */}
     </>