Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite connection demands password #396

Closed
T1mL3arn opened this issue Sep 25, 2019 · 3 comments
Closed

SQLite connection demands password #396

T1mL3arn opened this issue Sep 25, 2019 · 3 comments
Assignees
Labels

Comments

@T1mL3arn
Copy link

Describe the bug

SQLite connection demands password.

To Reproduce

Execute command 'Add New Connection' and choose SQLite. You can see askForPassword setting is true.

sqlite pass

Also it forces vscode to prompt a password input dialog when testing connection (it accepts any password except an empty).

passw input

There is no need for a password for SQLite, that setting should be false by default.

Desktop:

  • SQLTools 0.21.0
  • VSCode 1.37.1
  • Dialect Used/Version: SQLite
@drk-mtr
Copy link

drk-mtr commented Sep 25, 2019

I just came along to log this and saw it's already captured.

Firstly - thank you for the brilliant plugin! I love not having to leave vscode and have found it really useful - and I really like a lot of the design choices that have been made.

I was a bit confused by this one. I like the fact that we get to see a summary of the json schema when adding the connection. However it would be brilliant if we had the ability to amend parameters in the json (such as the password prompt) at this point - or if there was a note to advise us that the settings are stored in vscode's settings.json file. Otherwise reviewing this json for something we don't have the ability to change seems somewhat redundant.

@mtxr mtxr added bug and removed triage labels Sep 28, 2019
@mtxr mtxr self-assigned this Sep 28, 2019
@mtxr mtxr closed this as completed in b432e16 Sep 28, 2019
@brandonlipman
Copy link

Is there a way to locally make this patch or best to wait for an update to roll out?

@mtxr
Copy link
Owner

mtxr commented Sep 30, 2019

If you remove askForPassword from your settings file, it will be working fine.

Anyway, I plan to release it today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants