Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust 'black' code to support version 18 as well #943

Closed
wants to merge 1 commit into from

Conversation

keith-packard
Copy link
Contributor

Version 18 of 'black' has a slightly different API; check which
version we've managed to load and adapt on the fly

Signed-off-by: Keith Packard keithp@keithp.com

@ntoll
Copy link
Member

ntoll commented Oct 16, 2019

Hi @keith-packard..! Thank you for the contribution. Just so we get some context here, why does Mu need to support version 18 when version 19 is already released..?

@keith-packard
Copy link
Contributor Author

Hi @keith-packard..! Thank you for the contribution. Just so we get some context here, why does Mu need to support version 18 when version 19 is already released..?

Debian stable ships version 18, and I need to use that release. With this change, mu runs great.

Note that setup.py requires version 18, not 19, so this change is required to actually work when that is the version available.

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2019

This pull request introduces 1 alert when merging 30f8ec0 into ee600ff - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Version 18 of 'black' has a slightly different API; check which
version we've managed to load and adapt on the fly

Signed-off-by: Keith Packard <keithp@keithp.com>

--

v2:
	reformat code to fit in 79 columns
	fix coverage tests
v3:
	pass exceptions not related to black version through
	avoid importing all of 'black'
@carlosperate
Copy link
Member

Sorry Keith! I missed this PR when creating #1519. I'll close this one the other has already been merged.

Thanks again for the contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants